Goal This query identifies performance and concurrency bottlenecks caused by excessive locking. It flags INSERT, UPDATE, or DELETE statements that utilize subqueries containing the FOR UPDATE clause. Using FOR UPDATE acquires an exclusive lock, which is semantically inappropriate if the rows in the subquery are merely being read for reference or validation rather than being modified. This practice degrades system concurrency by unnecessarily blocking other transactions.
Notes Refers to the column pg_proc.prokind and thus works starting from PostgreSQL 11. A SELECT ... FOR UPDATE query can appear as the data source of an INSERT statement, within a WHERE, FROM, or USING subquery, or inside a Common Table Expression (WITH clause). For better readability in a web browser, the query escapes < characters, replaces newline characters with HTML line break (br) tags, and highlights FOR UPDATE between and tags in the returned routine body. Because multiple routines in the same schema can share a name (function overloading), routine parameters are also included alongside the schema and routine name for unique identification.
Type Problem detection Each row in the result could represent a flaw in the design
Reliability Medium Medium number of false-positive results
License MIT (opens in new tab)
Data Source INFORMATION_SCHEMA+system catalog
SQL Query
WITH routines_src AS (
  SELECT 
    pg_namespace.nspname AS routine_schema, 
    pg_proc.proname AS routine_name, 
    pg_get_function_identity_arguments(pg_proc.oid) AS parameters,
    CASE 
      WHEN pg_proc.prokind = 'f' THEN 'FUNCTION'
      WHEN pg_proc.prokind = 'p' THEN 'PROCEDURE'
      WHEN pg_proc.prokind = 'w' THEN 'WINDOW FUNCTION' 
    END AS routine_type,
    CASE 
      WHEN pg_proc.prokind <> 'a' THEN pg_get_functiondef(pg_proc.oid) 
      ELSE NULL 
    END AS raw_src
  FROM 
    pg_catalog.pg_proc
    INNER JOIN pg_catalog.pg_namespace ON pg_proc.pronamespace = pg_namespace.oid
  WHERE 
    pg_proc.prokind <> 'a'
    AND pg_proc.proname NOT IN (
      'f_assume_you_must_use_files', 
      'f_check_format_comma_separated_list', 
      'f_check_password', 
      'f_default_value_with_no_match'
    ) 
    AND pg_namespace.nspname NOT IN (
      SELECT schema_name
      FROM INFORMATION_SCHEMA.schemata
      WHERE schema_name <> 'public' 
        AND schema_owner = 'postgres' 
        AND schema_name IS NOT NULL
    )
)
SELECT 
  routine_schema, 
  routine_name, 
  parameters,
  routine_type,
  regexp_replace(
    regexp_replace(
      regexp_replace(raw_src, '<', '&lt', 'g'),
      '[\r\n]', '<br>', 'g'
    ),
    'FOR[[:space:]]+UPDATE', '<b>FOR UPDATE</b>', 'gi'
  ) AS routine_src
FROM routines_src
WHERE (
    raw_src ~* '\y(INSERT[[:space:]]+INTO|UPDATE[[:space:]]+[[:alnum:]_."]+|DELETE[[:space:]]+FROM)\y[^;]+\ySELECT\y(?=[^;]+\yFROM\y[^;]+\yFOR[[:space:]]+UPDATE\y)'
    OR     
    raw_src ~* '\yWITH\y[^;]+\ySELECT\y[^;]+\yFOR[[:space:]]+UPDATE\y[^;]+\y(INSERT[[:space:]]+INTO|UPDATE[[:space:]]+[[:alnum:]_."]+|DELETE[[:space:]]+FROM)\y'
  )
  AND raw_src !~* '\yxmin\y'
ORDER BY routine_schema, routine_name, parameters;

Fixing Suggestion

A weaker lock mode, such as FOR SHARE, is generally sufficient to ensure referential integrity without preventing concurrent reads.

Collections

This query belongs to the following collections:

Find problems automatically

Queries, that results point to problems in the database. Each query in the collection produces an initial assessment. However, a human reviewer has the final say as to whether there is a problem or not .

NameDescription
Find problems automaticallyQueries, that results point to problems in the database. Each query in the collection produces an initial assessment. However, a human reviewer has the final say as to whether there is a problem or not .

Categories

This query is classified under the following categories:

Concurrency control

Queries of this category provide information about concurrency control.

Does not work in some earlier PostgreSQL version

Queries of this category provide information that was not available in some earlier PostgreSQL version

Transactions

Queries of this catergory provide information about the use of transactions.

User-defined routines

Queries of this category provide information about the user-defined routines

NameDescription
Concurrency controlQueries of this category provide information about concurrency control.
Does not work in some earlier PostgreSQL versionQueries of this category provide information that was not available in some earlier PostgreSQL version
TransactionsQueries of this catergory provide information about the use of transactions.
User-defined routinesQueries of this category provide information about the user-defined routines