Find as to whether PL/pgSQL routines and SQL routines that do not have SQL-standard body use different syntax for casting (cast function vs :: operator).
Notes
Refers to the column pg_proc.prokind and thus works starting from PostgreSQL 11. In the returned body of routine the query replaces each newline character with the line break (br) tag for the better readability in case the query result is displayed in a web browser. There could be multiple routines with the same name but with different parameters in the same schema (overloading). Thus, for the unique identification of the routine it is necessary to present also its parameters in addition to the schema name and routine name. The query returns information about all routines that use casting if at least one routine uses cast and at least one routine uses ::. The query excludes routines that are a part of an extension.
Type
Problem detection (Each row in the result could represent a flaw in the design)
WITH routines_with_casting AS (SELECT
n.nspname AS routine_schema,
pr.proname AS routine_name,
pg_get_function_identity_arguments(pr.oid) AS parameters,
pg_get_functiondef(pr.oid) AS routine_src_original,
regexp_replace(pg_get_functiondef(pr.oid),'[\r\n]',' ','g') AS routine_src,
CASE WHEN pr.prokind='f' THEN 'FUNCTION'
WHEN pr.prokind='p' THEN 'PROCEDURE'
WHEN pr.prokind='w' THEN 'WINDOW FUNCTION' END AS routine_type,
l.lanname AS routine_language
FROM
pg_catalog.pg_proc pr,
pg_catalog.pg_namespace n,
pg_catalog.pg_language l
WHERE
pr.pronamespace = n.oid
AND pr.prolang=l.oid
AND pr.prokind<>'a'
AND pg_get_functiondef(pr.oid)~*'(\:\:|cast[(])'
AND pr.proname NOT IN ('f_assume_you_must_use_files', 'f_check_format_comma_separated_list', 'f_check_password', 'f_default_value_with_no_match')
AND NOT EXISTS (SELECT 1
FROM pg_catalog.pg_depend d
WHERE EXISTS (SELECT 1
FROM pg_catalog.pg_extension e
WHERE d.refobjid=e.oid) AND
d.objid=pr.oid)
AND n.nspname NOT IN (SELECT schema_name
FROM INFORMATION_SCHEMA.schemata
WHERE schema_name<>'public' AND
schema_owner='postgres' AND schema_name IS NOT NULL))
SELECT routine_schema, routine_name, parameters, routine_src, routine_type, routine_language
FROM routines_with_casting
WHERE EXISTS (SELECT * FROM routines_with_casting WHERE routine_src_original~*'\:\:')
AND EXISTS (SELECT * FROM routines_with_casting WHERE routine_src_original~*'cast[(]')
ORDER BY routine_schema, routine_name, parameters;
Collections
This query belongs to the following collections:
Name
Description
Find problems automatically
Queries, that results point to problems in the database. Each query in the collection produces an initial assessment. However, a human reviewer has the final say as to whether there is a problem or not .
Categories
This query is classified under the following categories:
Name
Description
Syntactics
Queries of this category provide information about syntactic mistakes.
User-defined routines
Queries of this category provide information about the user-defined routines