Query goal: | Find user-defined routines and derived tables (views/materialized views) that have a subquery that contain an invocation of Coalesce or Concat function with just one argument. You should use the Coalesce and Concat functions correctly by invoking these with at least two arguments. If one invokes these functions with one argument, then the functions will return the input value. |
Notes about the query: | Refers to the column pg_proc.prokind and thus works starting from PostgreSQL 11. The query uses system information function pg_get_viewdef to get the view subquery pretty printed, i.e., without excessive brackets. The query does not consider the routines that are a part of an extension. In the returned body of subquery of view/materialized view/routine the query replaces each newline character with the line break (br) tag for the better readability in case the query result is displayed in a web browser. There could be multiple routines with the same name but with different parameters in the same schema (overloading). Thus, for the unique identification of the routine it is necessary to present also its parameters in addition to the schema name and routine name. If the arguments of the invocation have brackets, then the query returns false positive results. |
Query type: | Problem detection (Each row in the result could represent a flaw in the design) |
Query reliability: | Low (Many false-positive results) |
Query license: | MIT License |
Fixing suggestion: | Add additional arguments to the invocation or remove the invocation. |
Data source: | INFORMATION_SCHEMA+system catalog |
SQL query: | Click on query to copy it
WITH derived_tables AS (SELECT n.nspname AS schema_name, c.relname AS object_name, CASE WHEN c.relkind='v' THEN 'VIEW' WHEN c.relkind='m' THEN 'MATERIALIZED VIEW' END AS object_type, pg_get_viewdef(c.oid, true) AS object_definition, regexp_replace(pg_get_viewdef(c.oid, true),'[\r\n]','<br>','g') AS object_def FROM pg_namespace AS n INNER JOIN pg_authid AS a ON n.nspowner=a.oid INNER JOIN pg_class AS c ON n.oid=c.relnamespace WHERE (n.nspname='public' OR a.rolname<>'postgres') AND relkind IN ('v','m')), routines AS (SELECT pg_namespace.nspname AS schema_name, pg_proc.proname || '(' || pg_get_function_identity_arguments(pg_proc.oid) || ')' AS object_name, CASE WHEN pg_proc.prokind='f' THEN 'FUNCTION' WHEN pg_proc.prokind='p' THEN 'PROCEDURE' WHEN pg_proc.prokind='w' THEN 'WINDOW FUNCTION' END AS object_type, pg_get_functiondef(pg_proc.oid) AS object_definition, regexp_replace( regexp_replace(pg_get_functiondef(pg_proc.oid),'<','<','g'),'[\r\n]','<br>','g') AS object_def FROM pg_catalog.pg_proc, pg_catalog.pg_namespace WHERE pg_proc.pronamespace = pg_namespace.oid AND pg_proc.prokind<>'a' AND pg_proc.proname NOT IN ('f_assume_you_must_use_files', 'f_check_format_comma_separated_list', 'f_check_password', 'f_default_value_with_no_match') AND pg_namespace.nspname NOT IN (SELECT schema_name FROM INFORMATION_SCHEMA.schemata WHERE schema_name<>'public' AND schema_owner='postgres' AND schema_name IS NOT NULL) AND NOT EXISTS (SELECT 1 FROM pg_catalog.pg_depend d WHERE EXISTS (SELECT 1 FROM pg_catalog.pg_extension e WHERE d.refobjid=e.oid) AND d.objid=pg_proc.oid)), checked_elements AS (SELECT schema_name, object_name, object_type, object_definition, object_def FROM derived_tables UNION SELECT schema_name, object_name, object_type, object_definition, object_def FROM routines) SELECT schema_name, object_name, object_type, object_def FROM checked_elements WHERE object_definition ~*'[[:space:]](coalesce|concat|concat_ws)[[:space:]]*[(][^,]+[)]' ORDER BY schema_name, object_type, object_name; |
Category name | Category description |
---|---|
Derived tables | Queries of this category provide information about the derived tables (views, materialized views), which are used to implement virtual data layer. |
Does not work in some earlier PostgreSQL version | Queries of this category provide information that was not available in some earlier PostgreSQL version |
System-defined functions | Queries of this category provide information about the use of system-defined functions. |
User-defined routines | Queries of this category provide information about the user-defined routines |
Reference |
---|
http://www.postgresqltutorial.com/postgresql-coalesce/ |