| Goal | Find domains that are not used in case of any base table column and routine (input or otput) parameter (as their type). Do not keep in your database elements that are not needed by anybody. These should be put in use or dropped, otherwise these are dead code. |
|---|---|
| Type | Problem detection (Each row in the result could represent a flaw in the design) |
| Reliability | High (Few or no false-positive results) |
| License | MIT (opens in new tab) |
| Fixing Suggestion | Use the domain at least once or drop it. It is possible that a domain is used as the type of a variable in a routine. In this case dropping the domain succeeds although it invalidates the routine. |
| Data Source | system catalog only |
| SQL Query |
|
SQL statements that help generate fixes for the identified problem.
Fix Action #1
WITH input_parameters AS (SELECT unnest(proargtypes) AS parameter_type
FROM pg_proc),
unused_domains AS (SELECT n.nspname AS domain_schema,
t.typname AS domain_name
FROM pg_type AS t INNER JOIN pg_namespace AS n ON n.oid=t.typnamespace
INNER JOIN pg_authid AS a ON n.nspowner=a.oid
WHERE (n.nspname='public' OR rolname<>'postgres')
AND t.typtype='d'
AND NOT EXISTS (SELECT 1
FROM pg_attribute
WHERE pg_attribute.atttypid=t.oid)
AND NOT EXISTS (SELECT 1
FROM pg_proc
WHERE pg_proc.prorettype=t.oid)
AND NOT EXISTS (SELECT 1
FROM input_parameters
WHERE input_parameters.parameter_type=t.oid))
SELECT format('DROP DOMAIN %1$I.%2$I RESTRICT;', domain_schema, domain_name) AS statements
FROM unused_domains
ORDER BY domain_schema, domain_name ;Drop the domain.
| SQL Query to Generate Fix | Description |
|---|---|
| Drop the domain. |
Collections
This query belongs to the following collections:
Find problems automatically
Queries, that results point to problems in the database. Each query in the collection produces an initial assessment. However, a human reviewer has the final say as to whether there is a problem or not .
| Name | Description |
|---|---|
| Find problems automatically | Queries, that results point to problems in the database. Each query in the collection produces an initial assessment. However, a human reviewer has the final say as to whether there is a problem or not . |
Categories
This query is classified under the following categories:
Comfortability of database evolution
Queries of this category provide information about the means that influence database evolution.
Domains
Queries of this category provide information about reusable specifications of column properties.
Unused implementation elements
Queries of this catergory provide information about the database objects that are not used.
| Name | Description |
|---|---|
| Comfortability of database evolution | Queries of this category provide information about the means that influence database evolution. |
| Domains | Queries of this category provide information about reusable specifications of column properties. |
| Unused implementation elements | Queries of this catergory provide information about the database objects that are not used. |
Further reading and related materials:
The corresponding code smells in case of cleaning code are "F4: Dead Function" and "G9: Dead Code". (Robert C. Martin, Clean Code)
| Reference |
|---|
| https://en.wikipedia.org/wiki/Dead_code |
| The corresponding code smells in case of cleaning code are "F4: Dead Function" and "G9: Dead Code". (Robert C. Martin, Clean Code) |