| 741 |
Routines with type casting |
Make sure that your parameters have appropriate types in order to avoid unnecessary type casting. |
General |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-19 11:02 |
MIT License |
View |
| 742 |
ROW-level BEFORE and INSTEAD OF triggers with RETURN NULL |
Such triggers effectively cancel data modification. It might be correct but could also be a mistake. "Row-level triggers fired BEFORE can return null to signal the trigger manager to skip the rest of the operation for this row (i.e., subsequent triggers are not fired, and the INSERT/UPDATE/DELETE does not occur for this row). " (PostgreSQL documentation) "INSTEAD OF triggers (which are always row-level triggers, and may only be used on views) can return null to signal that they did not perform any updates, and that the rest of the operation for this row should be skipped (i.e., subsequent triggers are not fired, and the row is not counted in the rows-affected status for the surrounding INSERT/UPDATE/DELETE). " (PostgreSQL documentation) |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-02-25 17:30 |
MIT License |
View |
| 743 |
ROW level BEFORE DELETE and INSTEAD OF DELETE triggers that procedures refer to the row variable NEW |
Do not write incorrect code. Variable NEW: "Data type RECORD; variable holding the new database row for INSERT/UPDATE operations in row-level triggers. This variable is null in statement-level triggers and for DELETE operations." (PostgreSQL documentation) |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-28 11:31 |
MIT License |
View |
| 744 |
ROW level BEFORE INSERT and INSTEAD OF INSERT triggers that procedures refer to the row variable OLD |
Do not write incorrect code. Variable OLD: "Data type RECORD; variable holding the old database row for UPDATE/DELETE operations in row-level triggers. This variable is null in statement-level triggers and for INSERT operations." (PostgreSQL documentation) |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-28 11:27 |
MIT License |
View |
| 745 |
ROW level BEFORE triggers that do not return a row if a check succeeds |
Find ROW level BEFORE triggers that check a condition based on other rows, raise an exception but do not return the row if the condition check succeeds, i.e., exception is not raised. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-16 12:41 |
MIT License |
View |
| 746 |
ROW level BEFORE triggers with RAISE EXCEPTION but without RETURN NULL |
Although RAISE EXCEPTION stops the execution it would be a good style to still return. In this case the return should bring back NULL, i.e., the row will not be processed further |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-02-25 17:30 |
MIT License |
View |
| 747 |
ROW level BEFORE UPDATE triggers that do not return the new row |
Find row level BEFORE UPDATE triggers that do not return the new row version. Exclude triggers that raise WARNING/EXCEPTION. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2022-12-08 15:59 |
MIT License |
View |
| 748 |
Row level triggers that update or delete data |
Find row level triggers that update or delete data. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-11 12:27 |
MIT License |
View |
| 749 |
Rules with the same name in different schemas |
Find rule names that are used in a database in more than one schema. Different things should have different names. But here different rules have the same name. Also make sure that this is not a duplication. |
General |
system catalog base tables only |
2020-11-06 14:51 |
MIT License |
View |
| 750 |
Rules with the same name within the same schema |
Find names of rules that are used within the same schema more than once. Give different triggers different names. |
Problem detection |
system catalog base tables only |
2021-02-25 17:30 |
MIT License |
View |
| 751 |
search_path should not be between quotation marks |
Write security definer functions securely. Give to the DBMS correctly information about the sequence of schemas that constitute the search path. You shouldn't write search path value between quotation marks or apostrophes. Thus, instead of writing SET search_path = "public, pg_temp"; or SET search_path = 'public, pg_temp'; you should write SET search_path = public, pg_temp; |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-11-03 21:10 |
MIT License |
View |
| 752 |
SECURITY DEFINER procedures cannot end transactions |
You cannot use COMMIT and ROLLBACK in a SECURITY DEFINER procedure. Procedures appeared in PostgreSQL 11. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-11-04 12:12 |
MIT License |
View |
| 753 |
SECURITY INVOKER routines that access data |
Find SECURITY INVOKER routines that read rows from a table, add rows to a table, update rows in a table, or delete rows from a table. Better to have for these purposes SECURITY DEFINER routines, which make it possible to give to the users privileges to only execute routines without having rights to access their underlying tables. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-11-04 10:44 |
MIT License |
View |
| 754 |
SELECT * in a routine body |
SELECT statement should list the columns not use SELECT * to return data from all the columns. Firstly, it ensures, that the query asks only data that is really needed by the routine. It means less data that the DBMS has to fetch and pass to the routine. It could also mean that the DBMS can answer to a query based on an index without reading table blocks. Secondly, it documents the data that is returned by the query. The query does not consider objects that are a part of an extension. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-13 14:34 |
MIT License |
View |
| 755 |
Sequence generators not needed |
Find possible classifier tables that have a column with a sequence generator. Such tables should have natural keys instead of surrogate keys. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2024-12-18 10:00 |
MIT License |
View |
| 756 |
Sequences that are not owned by a table column |
Find sequence generators that are not owned by a table column, i.e., if one drops the table or the column, then the sequence generator stays in place. |
Problem detection |
system catalog base tables only |
2023-10-06 14:40 |
MIT License |
View |
| 757 |
SET DEFAULT compensatory action is unsuitable |
Find foreign keys with SET DEFAULT compensatory action where the foreign key column does not have a default value. Compensatory actions cannot make changes that violate integrity constraints in a database. SET DEFAULT means that there shoud be a default value at the foreign key column. |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-02-25 17:30 |
MIT License |
View |
| 758 |
SET NULL compensatory action is unsuitable |
Find foreign key constraints that use a SET NULL compensating action but a foreign key column is mandatory, i.e., does not permit NULLs. Compensatory actions cannot make changes that violate integrity constraints in a database. SET NULL cannot put NULL to a mandatory column (delete a foreign key value). |
Problem detection |
INFORMATION_SCHEMA+system catalog base tables |
2021-02-25 17:30 |
MIT License |
View |
| 759 |
Set operations that do not remove duplicate rows in derived tables |
Find derived tables (views and materialized views) that use a set theoretic operation (union, except or intersect) in a manner that does not remove duplicate rows and thus can produce a multiset not a set. Make sure that it is what is needed. |
General |
INFORMATION_SCHEMA+system catalog base tables |
2020-12-10 13:32 |
MIT License |
View |
| 760 |
Short cycle (columns) |
Find cases where two candidate keys of the same table that are also foreign keys reference to each other. |
Problem detection |
system catalog base tables only |
2021-11-28 02:08 |
MIT License |
View |